[8.0] Make TaskBatcher Less Lock-Heavy (#82227)#82624
Merged
elasticsearchmachine merged 1 commit intoelastic:8.0from Jan 14, 2022
original-brownbear:backport/8.0/pr-82227
Merged
[8.0] Make TaskBatcher Less Lock-Heavy (#82227)#82624elasticsearchmachine merged 1 commit intoelastic:8.0from original-brownbear:backport/8.0/pr-82227
elasticsearchmachine merged 1 commit intoelastic:8.0from
original-brownbear:backport/8.0/pr-82227
Conversation
In many shards benchmarks we see a lot of contention when submitting tasks. This is obvious when working with lots of large task batches and doing long iterations. We don't need to lock in `runIfNotProcessed` past removign the task set for a key and can be a little more efficient when it comes to creating the new tasks set in `submitTasks` as well. Also, we don't need to use a fully locking map as we often have operations for different batching keys interleaved so moving to CHM as well. This change is particularly relevant for stability because we often submit tasks from network threads directly where grinding through a e.g. bunch of shard state updates and having to lock on the map over and over while e.g. a huge batch of index create or so was iterated over in `runIfNotProcessed` caused very visible latency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 8.0: