Watcher fix testTriggeredWatchLoading#82155
Merged
elasticsearchmachine merged 1 commit intoelastic:masterfrom Dec 30, 2021
Merged
Watcher fix testTriggeredWatchLoading#82155elasticsearchmachine merged 1 commit intoelastic:masterfrom
elasticsearchmachine merged 1 commit intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Contributor
Author
|
@martijnvg - Can you please do a quick post review merge review ? I had assumed that |
Member
|
LGTM! And this test hasn't failed since December 22th. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In all reported cases it appears that the found count is > expected count.
It is suspected that there are some Watches from previous tests
still pending in the .triggered_watches index causing extra Watches to be executed.
The change here is to ensure that .triggered_watches is removed prior to the
test run ensuing a clean slate.
closes #67729