Skip to content

TSDB: Add security tests for _tsid#81382

Merged
csoulios merged 2 commits intoelastic:masterfrom
csoulios:tsid-security-tests
Dec 9, 2021
Merged

TSDB: Add security tests for _tsid#81382
csoulios merged 2 commits intoelastic:masterfrom
csoulios:tsid-security-tests

Conversation

@csoulios
Copy link
Copy Markdown
Contributor

@csoulios csoulios commented Dec 6, 2021

This is a follow up to #80276

Relates to #74660

@csoulios csoulios added >test Issues or PRs that are addressing/adding tests :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC :StorageEngine/TSDB You know, for Metrics v8.1.0 labels Dec 6, 2021
@elasticmachine elasticmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Security Meta label for security team labels Dec 6, 2021
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Dec 6, 2021

Pinging @elastic/es-analytics-geo (Team:Analytics)

@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Dec 6, 2021

Pinging @elastic/es-security (Team:Security)

@csoulios csoulios mentioned this pull request Dec 6, 2021
Closed
@csoulios csoulios changed the title [TSDB] Add security tests for _tsid TSDB: Add security tests for _tsid Dec 6, 2021
@salvatore-campagna
Copy link
Copy Markdown
Contributor

salvatore-campagna commented Dec 9, 2021 •
edited
Loading

LGTM. Just a few questions:

  • The routing_path is used in such a way to have all documents with the same value for metricset and k8s.pod.uid in the same shard?
  • In the last test the API failing is the search API even if security.put_role uses a match query on _tsid (which should not be allowed), right?
  • Why we do not allow queries on the _tsid?

@csoulios
Copy link
Copy Markdown
Contributor Author

csoulios commented Dec 9, 2021

@elasticmachine update branch

@csoulios csoulios merged commit 8fc9ba7 into elastic:master Dec 9, 2021
@csoulios csoulios deleted the tsid-security-tests branch December 9, 2021 13:40
@wchaparro wchaparro assigned csoulios and unassigned csoulios Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nik9000 nik9000 nik9000 approved these changes

@salvatore-campagna salvatore-campagna salvatore-campagna approved these changes

Assignees

No one assigned

Labels

:Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC :StorageEngine/TSDB You know, for Metrics Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Security Meta label for security team >test Issues or PRs that are addressing/adding tests v8.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@csoulios @elasticmachine @salvatore-campagna @nik9000