Adjust LinuxFileSystemNatives.allocatedSizeInBytes for aarch64 architectures#81376
Merged
tlrx merged 1 commit intoelastic:masterfrom Dec 7, 2021
Merged
Adjust LinuxFileSystemNatives.allocatedSizeInBytes for aarch64 architectures#81376tlrx merged 1 commit intoelastic:masterfrom
tlrx merged 1 commit intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
approved these changes
Dec 7, 2021
Comment on lines
+46
to
+52
| * For x86-64 the _STAT_VER used is: | ||
| * # define _STAT_VER_LINUX 1 | ||
| * # define _STAT_VER _STAT_VER_LINUX | ||
| * | ||
| * For other architectures the _STAT_VER used is: | ||
| * # define _STAT_VER_LINUX 0 | ||
| * # define _STAT_VER _STAT_VER_LINUX |
Member
There was a problem hiding this comment.
We really need #80903 to deal with this sort of nonsense.
Member
Author
There was a problem hiding this comment.
I agree, I'm a bit afraid if the _xstat function changes over time and we don't catch it before in our tests.
Member
Author
|
Thanks David! Let's see if that works now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native method added in #80437 requires some adjustments to work on
aarch64architectures, which hopefully this change addresses. The stat version has been tested on AWS 64-bit ARM instances (on ubuntu-18.04 and on Amazon Linux 2).Closes #81362