TSDB: Add unsigned_long dimension fields to _tsid#81284
Merged
csoulios merged 3 commits intoelastic:masterfrom Dec 9, 2021
Merged
TSDB: Add unsigned_long dimension fields to _tsid#81284csoulios merged 3 commits intoelastic:masterfrom
unsigned_long dimension fields to _tsid#81284csoulios merged 3 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
csoulios
commented
Dec 2, 2021
| - match: {hits.hits.1.fields.ul: [9223372036854775807]} | ||
|
|
||
| --- | ||
| # TODO: Sort order is wrong here. Probably this is caused by the encoding of unsigned_long |
Contributor
Author
There was a problem hiding this comment.
Sort order is broken when unsigned_long field is encoded in the _tsid. However, sort order is always consistent. Is there an easy fix for this? Can this be a problem we can live with?
Member
There was a problem hiding this comment.
I think so long as its consistent it's ok - though we should probably ask around a bit. I wonder what the sort order is for signed longs right now. I'll bet negative comes after positive because we're sorting bytes not numbers.
nik9000
approved these changes
Dec 6, 2021
Contributor
Author
|
@elasticmachine update branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on the work added in #80276 that generates the
_tsidfield forkeyword,ipandnumberdimension fields.It adds support for
unsigned_longdimension fields.