Skip to content

[7.16] [ML] Parent datafeed actions to the datafeed's persistent task (#81143)#81153

Merged
elasticsearchmachine merged 2 commits intoelastic:7.16from
dimitris-athanasiou:backport/7.16/pr-81143
Nov 30, 2021
Merged

[7.16] [ML] Parent datafeed actions to the datafeed's persistent task (#81143)#81153
elasticsearchmachine merged 2 commits intoelastic:7.16from
dimitris-athanasiou:backport/7.16/pr-81143

Conversation

@dimitris-athanasiou
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.16:

…ic#81143)

The vast majority of a datafeed's actions are executed from the
data extractor. This includes the heaviest actions which are the
searches. This commit passes a `ParentTaskAssigningClient` to
`DataExtractorFactory.create` which ensures the client used by
any extractor will be setting the corresponding task id: the action
task id for preview datafeed and the master operation stage of the
start datafeed action, and the persistent task id for the datafeed
operations after it has started.
@dimitris-athanasiou dimitris-athanasiou added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport labels Nov 30, 2021
@dimitris-athanasiou
Copy link
Copy Markdown
Contributor Author

As in the 7 branch we don't have access to the task in the masterOperation of a master node action, we don't parent the searches done in the original phase of the start datafeed API. But the heavy searches will be as part of the datafeed having actually started so we still get those parented.

@elasticsearchmachine elasticsearchmachine merged commit b3708dd into elastic:7.16 Nov 30, 2021
@dimitris-athanasiou dimitris-athanasiou deleted the backport/7.16/pr-81143 branch November 30, 2021 15:51
@danhermann danhermann added v7.16.0 and removed v7.16.1 labels Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport v7.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants