Skip to content

[8.0] [ML] Fix acceptable model snapshot versions in ML deprecation checker (#81060)#81101

Merged
elasticsearchmachine merged 1 commit intoelastic:8.0from
droberts195:backport/8.0/pr-81060
Nov 29, 2021
Merged

[8.0] [ML] Fix acceptable model snapshot versions in ML deprecation checker (#81060)#81101
elasticsearchmachine merged 1 commit intoelastic:8.0from
droberts195:backport/8.0/pr-81060

Conversation

@droberts195
Copy link
Copy Markdown

Backports the following commits to 8.0:

…elastic#81060)

This is a followup to elastic#81039.

The same requirement to tolerate model snapshots back to 6.4.0
that applies to the job opening code also applies to the deprecation
checker. Again, we tell the user that 7.0.0 is the model snapshot
version we support, but we actually have to support versions going
back to 6.4.0 because we didn't update the constant in the C++ in
7.0.0.

Additionally, the wording of the ML deprecation messages is very
slightly updated. The messages are different in the 7.16 branch,
where they were updated by elastic#79387. This wording is copied forward
to master, but with the tiny change that "Snapshot" is changed to
"Model snapshot" in one place. This should make it clearer for
users that we're talking about ML model snapshots and not cluster
snapshots (which are completely different things). Another reason
to change the wording is that the UI is looking for the pattern
/[Mm]odel snapshot/ to decide when to display the "Fix" button for
upgrading ML model snapshots - see elastic/kibana#119745.
@droberts195 droberts195 added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport labels Nov 29, 2021
@elasticsearchmachine elasticsearchmachine merged commit b6cf74c into elastic:8.0 Nov 29, 2021
@droberts195 droberts195 deleted the backport/8.0/pr-81060 branch November 29, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport v8.0.0-rc1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants