Delete watcher legacy templates#80915
Closed
andreidan wants to merge 4 commits intoelastic:masterfrom
Closed
Conversation
This adds a way to be able to remove multiple legacy index templates in one cluster state update.
We moved watcher to run on the system indices infrastructure in elastic#67588. This commit makes sure Watcher cleans up the legacy templates it used before it was migrated to system indices.
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
martijnvg
reviewed
Nov 23, 2021
Member
martijnvg
left a comment
There was a problem hiding this comment.
Looks good, I left a few comments.
| private volatile WatcherService watcherService; | ||
| private final EnumSet<WatcherState> stopStates = EnumSet.of(WatcherState.STOPPED, WatcherState.STOPPING); | ||
| private final AtomicBoolean legacyTemplatesDeleteInProgress = new AtomicBoolean(false); | ||
| private final AtomicBoolean checkForLegacyTemplates = new AtomicBoolean(true); |
Member
There was a problem hiding this comment.
Should checking whether a removal of templates is in progress be part of the functionality that MetadataIndexTemplateService.removeTemplates(...) method offers?
| e | ||
| ); | ||
| })); | ||
| } |
Member
There was a problem hiding this comment.
Should checkForLegacyTemplates be set to false when existingTemplatesToDelete list is empty?
| * | ||
| * The provided templates must exist in the cluster, otherwise an {@link IndexTemplateMissingException} is reported. | ||
| */ | ||
| public static void removeTemplates( |
Member
There was a problem hiding this comment.
maybe rename to removeLegacyTemplates? To emphasise this batch removal method is for legacy templates only.
Contributor
Author
|
Superseded by #80937 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a bit of infrastructure to be able to remove multiple legacy templates
with one cluster state update and removes the legacy watcher index templates.
Relates to #80853