Add Traceable interface#80788
Merged
elasticsearchmachine merged 4 commits intoelastic:feature/apm-integrationfrom Nov 17, 2021
Merged
Add Traceable interface#80788elasticsearchmachine merged 4 commits intoelastic:feature/apm-integrationfrom
elasticsearchmachine merged 4 commits intoelastic:feature/apm-integrationfrom
Conversation
Task now implements the Traceable interface. This allows other traceable entities to be developed.
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
ywangd
commented
Nov 17, 2021
Comment on lines
+67
to
+84
| for (Map.Entry<String, Object> entry : traceable.getAttributes().entrySet()) { | ||
| final Object value = entry.getValue(); | ||
| if (value instanceof String) { | ||
| span.setAttribute(entry.getKey(), (String) value); | ||
| } else if (value instanceof Long) { | ||
| span.setAttribute(entry.getKey(), (Long) value); | ||
| } else if (value instanceof Integer) { | ||
| span.setAttribute(entry.getKey(), (Integer) value); | ||
| } else if (value instanceof Double) { | ||
| span.setAttribute(entry.getKey(), (Double) value); | ||
| } else if (value instanceof Boolean) { | ||
| span.setAttribute(entry.getKey(), (Boolean) value); | ||
| } else { | ||
| throw new IllegalArgumentException( | ||
| "span attributes do not support value type of [" + value.getClass().getCanonicalName() + "]" | ||
| ); | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
This is not pretty. But it does the job for now and keep other parts unware of the opentelemetry dependencies. We can improve it once we know more about what other things needed by the new Traceable interface.
| void onRegistered(Traceable traceable); | ||
|
|
||
| void onTaskUnregistered(Task task); | ||
| void onUnregistered(Traceable traceable); |
Contributor
There was a problem hiding this comment.
I believe registered/unregistered is still related to the task naming.
Should generic methods be called onSpanStarted/onStarted or something similar?
Member
Author
There was a problem hiding this comment.
Thanks. I changed the method names to onTraceStarted and onTraceStopped.
…m/add-traceable-interface
| final Span span = tracer.spanBuilder(task.getAction()).startSpan(); | ||
| span.setAttribute("es.task.id", task.getId()); | ||
| spans.computeIfAbsent(traceable.getSpanId(), spanId -> { | ||
| final Span span = tracer.spanBuilder(traceable.getSpanName()).startSpan(); |
There was a problem hiding this comment.
When setting attributes while creating the span, it's common to use SpanBuilder.setAttribute(key, value). It would look like:
SpanBuilder spanBuilder = tracer.spanBuilder(traceable.getSpanName());
for (Map.Entry<String, Object> entry : traceable.getAttributes().entrySet()) {
Object value = entry.getValue();
if (value instanceof String) {
spanBuilder.setAttribute(entry.getKey(), (String) value);
} else if (value instanceof Long) {
spanBuilder.setAttribute(entry.getKey(), (Long) value);
} else if (value instanceof Integer) {
spanBuilder.setAttribute(entry.getKey(), (Integer) value);
} else if (value instanceof Double) {
spanBuilder.setAttribute(entry.getKey(), (Double) value);
} else if (value instanceof Boolean) {
spanBuilder.setAttribute(entry.getKey(), (Boolean) value);
} else {
throw new IllegalArgumentException(
"span attributes do not support value type of [" + value.getClass().getCanonicalName() + "]"
);
}
return spanBuilder.startSpan();
Member
Author
There was a problem hiding this comment.
Thanks I updated as suggested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task now implements the Traceable interface. This allows other traceable
entities to be developed.