Use OpenTelemetry with HTTP/gRPC exporters in apm-integration#80762
Merged
elasticsearchmachine merged 3 commits intoelastic:feature/apm-integrationfrom Nov 17, 2021
Merged
Conversation
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
AthenaEryma
approved these changes
Nov 17, 2021
Contributor
AthenaEryma
left a comment
There was a problem hiding this comment.
Not being at all familiar with the OpenTelemetry API, but having reviewed all the relevant PRs up until this point: LGTM.
ywangd
approved these changes
Nov 17, 2021
Member
ywangd
left a comment
There was a problem hiding this comment.
LGTM
Just need two more security permissions for allowing exporting data to a Cloud APM server.
I can also confirm the ApmIT teset run successful on my machine.
x-pack/plugin/apm-integration/src/main/plugin-metadata/plugin-security.policy
Show resolved
Hide resolved
SylvainJuge
approved these changes
Nov 17, 2021
…security.policy add permissions Co-authored-by: Yang Wang <ywangd@gmail.com>
Member
Author
|
Thanks everyone! |
DaveCTurner
reviewed
Nov 17, 2021
Member
DaveCTurner
left a comment
There was a problem hiding this comment.
Sorry for the late review, I was having too much fun playing around with it. LGTM2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for HTPP/gRPC with the OpenTelemetry SDK in the
apm-integrationplugin. It adds the required security permissions to the plugin to make it work - we should try to reduce this list one day.The plumbing to pass Elastic's Cloud APM server credentials is not fully there yet but the current
ApmITtest can be executed with-Dtests.apm.endpoint=https://... -Dtests.apm.token=ABCand traces should be sent to Elastic APM.Works on my machine™