Use Java 15 text blocks for JSON and multiline strings#80751
Merged
arteam merged 61 commits intoelastic:masterfrom Dec 15, 2021
Merged
Use Java 15 text blocks for JSON and multiline strings#80751arteam merged 61 commits intoelastic:masterfrom
arteam merged 61 commits intoelastic:masterfrom
Conversation
a403cb8 to
f39bc10
Compare
pugnascotia
reviewed
Nov 16, 2021
client/rest-high-level/src/test/java/org/elasticsearch/client/BulkProcessorIT.java
Outdated
Show resolved
Hide resolved
Contributor
|
I'm happy to go over this properly when we're in a position to merge 👍 |
9620029 to
9f0a77a
Compare
…ternal/docker/DockerSupportService.java Co-authored-by: Rory Hunter <pugnascotia@users.noreply.github.com>
…ternal/precommit/DependencyLicensesTask.java Co-authored-by: Rory Hunter <pugnascotia@users.noreply.github.com>
…documentation/SnapshotClientDocumentationIT.java Co-authored-by: Rory Hunter <pugnascotia@users.noreply.github.com>
…ustache/RestMultiSearchTemplateActionTests.java Co-authored-by: Rory Hunter <pugnascotia@users.noreply.github.com>
…security/ClearRealmCacheResponseTests.java Co-authored-by: Rory Hunter <pugnascotia@users.noreply.github.com>
…documentation/WatcherDocumentationIT.java Co-authored-by: Rory Hunter <pugnascotia@users.noreply.github.com>
…ava/org/elasticsearch/xpack/ml/integration/ExplainDataFrameAnalyticsIT.java Co-authored-by: Rory Hunter <pugnascotia@users.noreply.github.com>
…ava/org/elasticsearch/xpack/ml/integration/PyTorchModelIT.java Co-authored-by: Rory Hunter <pugnascotia@users.noreply.github.com>
…ava/org/elasticsearch/xpack/ml/integration/RegressionIT.java Co-authored-by: Rory Hunter <pugnascotia@users.noreply.github.com>
…csearch/integration/IndexPrivilegeIntegTests.java Co-authored-by: Rory Hunter <pugnascotia@users.noreply.github.com>
…al/DiscountedCumulativeGainTests.java Co-authored-by: Rory Hunter <pugnascotia@users.noreply.github.com>
…ack/sql/qa/geo/GeoDataLoader.java Co-authored-by: Rory Hunter <pugnascotia@users.noreply.github.com>
…pack/textstructure/structurefinder/GrokPatternCreatorTests.java Co-authored-by: Rory Hunter <pugnascotia@users.noreply.github.com>
pugnascotia
approved these changes
Dec 9, 2021
Contributor
pugnascotia
left a comment
There was a problem hiding this comment.
LGTM 👍 thanks for taking on this work! 🚀
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
Thanks, Rory! |
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ES code base is quite JSON heavy. It uses a lot of multi-line JSON requests in tests which need to be escaped and concatenated which in turn makes them hard to read. Let's try to leverage Java 15 text blocks for representing them.