Skip to content

Integrate tracer with task manager#80721

Merged
elasticsearchmachine merged 6 commits intoelastic:feature/apm-integrationfrom
DaveCTurner:2021-11-15-apm-integration-task-tracer
Nov 15, 2021
Merged

Integrate tracer with task manager#80721
elasticsearchmachine merged 6 commits intoelastic:feature/apm-integrationfrom
DaveCTurner:2021-11-15-apm-integration-task-tracer

Conversation

@DaveCTurner
Copy link
Copy Markdown
Member

No description provided.

@DaveCTurner DaveCTurner requested a review from tlrx November 15, 2021 14:47
@DaveCTurner DaveCTurner added :Distributed/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >enhancement labels Nov 15, 2021
@elasticmachine elasticmachine added the Team:Distributed Meta label for distributed team. label Nov 15, 2021
Copy link
Copy Markdown
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

assert false : e;
logger.warn(
new ParameterizedMessage(
"task tracing listener [{}] failed on registration of task [{}][{}]",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"task tracing listener [{}] failed on registration of task [{}][{}]",
"task tracing listener [{}] failed on unregistration of task [{}][{}]",

@DaveCTurner
Copy link
Copy Markdown
Member Author

@elasticmachine please run elasticsearch-ci/part-1

@DaveCTurner
Copy link
Copy Markdown
Member Author

@elasticmachine please run elasticsearch-ci/part-2

1 similar comment
@DaveCTurner
Copy link
Copy Markdown
Member Author

@elasticmachine please run elasticsearch-ci/part-2

@DaveCTurner DaveCTurner added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Nov 15, 2021
@elasticsearchmachine elasticsearchmachine merged commit ba34d70 into elastic:feature/apm-integration Nov 15, 2021
@DaveCTurner DaveCTurner deleted the 2021-11-15-apm-integration-task-tracer branch November 15, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >enhancement Team:Distributed Meta label for distributed team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants