Base module for APM Tracing#80705
Merged
elasticsearchmachine merged 2 commits intoelastic:feature/apm-integrationfrom Nov 15, 2021
Merged
Base module for APM Tracing#80705elasticsearchmachine merged 2 commits intoelastic:feature/apm-integrationfrom
elasticsearchmachine merged 2 commits intoelastic:feature/apm-integrationfrom
Conversation
idegtiarenko
approved these changes
Nov 15, 2021
| NamedWriteableRegistry namedWriteableRegistry, | ||
| ExecutorSelector executorSelector | ||
| ExecutorSelector executorSelector, | ||
| TracingPlugin.Tracer tracer |
Contributor
There was a problem hiding this comment.
Should we add this here? If we start by tracing tasks, we won't need this dependency in the search action.
Member
There was a problem hiding this comment.
It at least demonstrates that we're creating and registering it when creating the Node. We can drop it when we use the injected thing elsewhere.
Member
Author
There was a problem hiding this comment.
It at least demonstrates that we're creating and registering it
Yes, the purpose was to make the Tracer instance available for the next steps, whatever/wherever they will be
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.