Track remote as InetSocketAddress#80691
Merged
DaveCTurner merged 2 commits intoelastic:masterfrom Nov 15, 2021
Merged
Conversation
We record the sender of each inbound `TransportMessage` so that it can be recorded in the audit trail. Today we use a field of type `TransportAddress` which is a wrapper around the underlying `InetSocketAddress` that allows us to send the address over the wire. We create a new wrapper for each inbound message which is a little wasteful, and also completely unnecessary since we never actually send it over the wire. With this commit we skip the wrapping entirely and just use a bare `InetSocketAddress` to identify the inbound connection on which the message was received. Closes elastic#80690
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
idegtiarenko
approved these changes
Nov 15, 2021
Member
Author
|
Thanks both! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We record the sender of each inbound
TransportMessageso that it canbe recorded in the audit trail. Today we use a field of type
TransportAddresswhich is a wrapper around the underlyingInetSocketAddressthat allows us to send the address over the wire. Wecreate a new wrapper for each inbound message which is a little
wasteful, and also completely unnecessary since we never actually send
it over the wire.
With this commit we skip the wrapping entirely and just use a bare
InetSocketAddressto identify the inbound connection on which themessage was received.
Closes #80690