Add field usage support for vectors#80608
Conversation
|
Pinging @elastic/es-search (Team:Search) |
cbuescher
left a comment
There was a problem hiding this comment.
LGTM, left one note regarding possible problem with the rest test for mixed cluster tests
| @@ -0,0 +1,87 @@ | |||
| setup: | |||
There was a problem hiding this comment.
This test might need a skip section for <8.1 for mixed cluster tests.
There was a problem hiding this comment.
hmm, don't really understand why this passes test. Maybe we don't run these in x-pack on mixed clusters?
There was a problem hiding this comment.
yes, this validates my understanding (I deliberately did not add the version constraint to check if anything breaks on CI). I find the findings very worrying though.
There was a problem hiding this comment.
Good to see that we both expected this to fail in some way. Maybe worth some parallel investigation, I'd be interested in the results.
There was a problem hiding this comment.
It seems we don't have "mixed cluster" tests for x-pack like we do for the core apis. So we simply aren't running this test under that scenario at all. See #31096
There was a problem hiding this comment.
Wow, that's scary (and lol for linking to my own issue, guess my memory is failing me).
Perhaps that one needs to be reprioritized!
There was a problem hiding this comment.
The issue seems to be tagged as core/infra but I'm not sure if that's strictly correct. There's no real clear ownership of these large cross-functional test suites. It's really just a matter of adding a qa project for this under x-pack similar to the existing core one.
Add field usage tracking support for the new vectors functionality.