This commit includes more updates to deprecation info API message wor…#80144
Merged
masseyke merged 3 commits intoelastic:7.16from Nov 3, 2021
Merged
Conversation
…ding and URLs as a follow-up to elastic#79387
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
debadair
approved these changes
Nov 2, 2021
Contributor
debadair
left a comment
There was a problem hiding this comment.
Left one suggestion for one of the messages that didn't get edited, otherwise LGTM.
| + "] setting, " | ||
| + "in 8.0 this setting will be required for all indices and may not be empty or null.", | ||
| "https://www.elastic.co/guide/en/elasticsearch/reference/current/data-tiers.html", | ||
| "https://ela.st/es-deprecation-7-empty-tier-preference", |
Contributor
There was a problem hiding this comment.
I'd init cap index in the deprecation message, and tweak the description slightly:
Index "indexName" does not have a "DataTier.TIER_PREFERENCE" configured
A data tier preference must be specified for all indices in 8.0. Set a tier preference for "indexName".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit includes more updates to deprecation info API message wording and URLs as a follow-up to #79387