Apply the reader wrapper on can_match source#79794
Merged
jimczi merged 1 commit intoelastic:7.16from Oct 26, 2021
Merged
Conversation
Today we don't wrap the original index reader with the reader wrapper plugin if it is acquired from the can_match source. We've made this distinction to ensure that the wrapper plugin doesn't perform any IO during the can_match phase. Now that the security layer loads the role query lazily, this change removes the special path and applies the wrapper in all cases. It also adds an assert to ensure that the loading of the role query is never done on a transport thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #78988