Skip to content

[7.x] Remove getValue and getValues from Field (#79516)#79523

Merged
jdconrad merged 1 commit intoelastic:7.xfrom
jdconrad:bp79516
Oct 19, 2021
Merged

[7.x] Remove getValue and getValues from Field (#79516)#79523
jdconrad merged 1 commit intoelastic:7.xfrom
jdconrad:bp79516

Conversation

@jdconrad
Copy link
Copy Markdown
Contributor

@jdconrad jdconrad commented Oct 19, 2021

Backports the following commits to 7.x:

With duck-typing in Painless and potentially non-dynamic languages requiring a cast under the
current design, this change removes unnecessary methods from the Field base class. The removal of
getValue and getValues allows sub classes to return primitives from these methods and opens up
potential design space for performance improvements.

Note this removes getLong from the unsigned long field; however, this is currently undocumented and
unused behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants