Skip to content

Preserve request headers in a mixed version cluster (#79412)#79439

Merged
elasticsearchmachine merged 2 commits intoelastic:7.xfrom
ywangd:es-79354-rewrite-security-headers-7.x
Oct 19, 2021
Merged

Preserve request headers in a mixed version cluster (#79412)#79439
elasticsearchmachine merged 2 commits intoelastic:7.xfrom
ywangd:es-79354-rewrite-security-headers-7.x

Conversation

@ywangd
Copy link
Copy Markdown
Member

@ywangd ywangd commented Oct 19, 2021

When rewriting authentication for requests crossing nodes of different
versions, we now preserve all request headers except the authentication
one which needs to be rewritten. Previously all other request headers
were dropped and it caused issue like an operator user not being
recognised on the remote node. Other now preserved headers include audit
and system index access. This new behaviour is more correct because we
would never drop these headers if the nodes are on the same version.

Resolves: #79354

When rewriting authentication for requests crossing nodes of different
versions, we now preserve all request headers except the authentication
one which needs to be rewritten. Previously all other request headers
were dropped and it caused issue like an operator user not being
recognised on the remote node. Other now preserved headers include audit
and system index access. This new behaviour is more correct because we
would never drop these headers if the nodes are on the same version.

Resolves: elastic#79354
@ywangd ywangd added backport auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Oct 19, 2021
@ywangd ywangd added v7.16.0 and removed v7.16.1 labels Oct 19, 2021
@ywangd
Copy link
Copy Markdown
Member Author

ywangd commented Oct 19, 2021

@elasticmachine run elasticsearch-ci/part-2

@ywangd
Copy link
Copy Markdown
Member Author

ywangd commented Oct 19, 2021

@elasticmachine update branch

@elasticsearchmachine elasticsearchmachine merged commit 74ba6fb into elastic:7.x Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport v7.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants