Fix path.data as comma separated string (#76202)#79272
Merged
rjernst merged 2 commits intoelastic:masterfrom Oct 18, 2021
Merged
Fix path.data as comma separated string (#76202)#79272rjernst merged 2 commits intoelastic:masterfrom
rjernst merged 2 commits intoelastic:masterfrom
Conversation
For multiple data paths, there are several allowed varieties of specifcying the paths. The yaml list forms, both single and multi line, are allowed, but another form is a string containing commas that is parsed as a list. This latter form was broken recently by the refactoring of path.data parsing to emit deprecation warnings for MDP. This commit fixes the comma separated string case and adds a test. closes elastic#76181
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Member
Author
|
This is actually a forward port of #76202, which is now applicable to master since MDP was added back. |
17 tasks
Member
Author
|
@elasticmachine run elasticsearch-ci/part-1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For multiple data paths, there are several allowed varieties of
specifcying the paths. The yaml list forms, both single and multi line,
are allowed, but another form is a string containing commas that is
parsed as a list. This latter form was broken recently by the
refactoring of path.data parsing to emit deprecation warnings for MDP.
This commit fixes the comma separated string case and adds a test.
closes #76181