Fork FirstPassGroupingCollector into a custom single pass collector#79224
Merged
jimczi merged 3 commits intoelastic:masterfrom Oct 20, 2021
Merged
Fork FirstPassGroupingCollector into a custom single pass collector#79224jimczi merged 3 commits intoelastic:masterfrom
jimczi merged 3 commits intoelastic:masterfrom
Conversation
This change rewrites the CollapsingTopDocsCollector into a SinglePassGroupingCollector. Relying on Lucene's FirstPassGroupingCollector is not safe, we have no guarantee that the underlying implementation will not break our custom extension in the future. It is also a blocker for the modularization of Elasticsearch since the extension class needs to access a Lucene's package protected field. So this commit forks the code of the FirstPassGroupingCollector into a specialized collector that we can control.
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
ChrisHegarty
approved these changes
Oct 15, 2021
Contributor
ChrisHegarty
left a comment
There was a problem hiding this comment.
This looks great @jimczi, thanks for taking it on. Much appreciated. ( please wait for a second more knowledgable area-specific reviewer )
romseygeek
approved these changes
Oct 15, 2021
Contributor
romseygeek
left a comment
There was a problem hiding this comment.
LGTM.
Do we want to contribute the SinglePassGroupingCollector back upstream? It seems to be a generally useful class that isn't coupled to any ES-specific code AIUI
58 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change rewrites the CollapsingTopDocsCollector into a
SinglePassGroupingCollector.
Relying on Lucene's FirstPassGroupingCollector is not safe,
we have no guarantee that the underlying implementation will
not break our custom extension in the future.
It is also a blocker for the modularization of Elasticsearch
since the extension class needs to access a Lucene's package
protected field.
So this commit forks the code of the FirstPassGroupingCollector
into a specialized collector that we can control.