Revert "Convert path.data to String setting instead of List (#72282)"#79091
Merged
rjernst merged 4 commits intoelastic:masterfrom Oct 14, 2021
Merged
Revert "Convert path.data to String setting instead of List (#72282)"#79091rjernst merged 4 commits intoelastic:masterfrom
rjernst merged 4 commits intoelastic:masterfrom
Conversation
…72282)" This reverts commit d933ecd. The revert had two conflicts. The first was very minor in JoinHelper. The second was several tests in PersistedClusterStateServiceTests. relates elastic#78525 relates elastic#71205
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
henningandersen
approved these changes
Oct 13, 2021
Contributor
henningandersen
left a comment
There was a problem hiding this comment.
LGTM (provided CI is happy).
| try (NodeEnvironment nodeEnvironment = newNodeEnvironment(dataPaths2)) { | ||
| try (Writer writer = newPersistedClusterStateService(nodeEnvironment).createWriter()) { | ||
| final PersistedClusterStateService.OnDiskState onDiskState = newPersistedClusterStateService(nodeEnvironment) | ||
| .loadBestOnDiskState(); |
Contributor
There was a problem hiding this comment.
Passing in false to loadBestOnDiskState here makes this test succeed.
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit d933ecd.
The revert had two conflicts. The first was very minor in JoinHelper.
The second was several tests in PersistedClusterStateServiceTests.
relates #78525
relates #71205