Enable DeprecationHttpIT and resetFeatures in MlDeprecationIT#79071
Merged
pgomulka merged 7 commits intoelastic:masterfrom Oct 14, 2021
Merged
Enable DeprecationHttpIT and resetFeatures in MlDeprecationIT#79071pgomulka merged 7 commits intoelastic:masterfrom
pgomulka merged 7 commits intoelastic:masterfrom
Conversation
droberts195
reviewed
Oct 13, 2021
Comment on lines
+92
to
+94
| // if data stream is still present, that means that previous test (could be different class) created a deprecation | ||
| // hence resetting again | ||
| resetDeprecationIndexAndCache(); |
There was a problem hiding this comment.
Ideally this bit wouldn't be necessary after adding the feature reset to the ML test. Are you seeing a case where it is still needed?
Contributor
Author
There was a problem hiding this comment.
I know, but I thought that if we have a new test and forget to clean up deprecation log this test would fail.
Or if for some reason the ML test failed cleanup, then this test would fail too.
I added it to a place where it is only executed after a check asserting about the deprecation index not existing failed
...ation/qa/rest/src/javaRestTest/java/org/elasticsearch/xpack/deprecation/MlDeprecationIT.java
Outdated
Show resolved
Hide resolved
…asticsearch/xpack/deprecation/MlDeprecationIT.java Co-authored-by: David Roberts <dave.roberts@elastic.co>
Contributor
Author
|
@elasticmachine update branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #79038
gradle check?