Store DataTier Preference directly on IndexMetadata (#78668)#78874
Merged
original-brownbear merged 2 commits intoelastic:7.xfrom Oct 8, 2021
original-brownbear:78668-7.x
Merged
Store DataTier Preference directly on IndexMetadata (#78668)#78874original-brownbear merged 2 commits intoelastic:7.xfrom original-brownbear:78668-7.x
original-brownbear merged 2 commits intoelastic:7.xfrom
original-brownbear:78668-7.x
Conversation
The data tier preference is very expensive to parse out of the setting string repeatedly for large number of indices when using it in the data tier allocation decider. => as done with other index settings relevant to allocation, this commit moves the data tier preference to a field in `IndexMetadata`. The required moving the `DataTier` class itself to `server`. In a follow-up we can look into making the setting a list setting to remove the duplication around turning the string value into a list in various places.
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The data tier preference is very expensive to parse out of the setting string
repeatedly for large number of indices when using it in the data tier allocation decider.
=> as done with other index settings relevant to allocation, this commit moves the data tier
preference to a field in
IndexMetadata. The required moving theDataTierclass itself toserver. In a follow-up we can look into making the setting a list setting to remove theduplication around turning the string value into a list in various places.
backport of #78668