Speed up toXContent Collection Serialization in some Spots (#78742)#78755
Merged
original-brownbear merged 1 commit intoelastic:7.xfrom Oct 6, 2021
original-brownbear:78742-7.x
Merged
Speed up toXContent Collection Serialization in some Spots (#78742)#78755original-brownbear merged 1 commit intoelastic:7.xfrom original-brownbear:78742-7.x
original-brownbear merged 1 commit intoelastic:7.xfrom
original-brownbear:78742-7.x
Conversation
Found this when benchmarking large cluster states. When serializing collections we'd mostly not take any advantage of what we know about the collection contents (like we do in `StreamOutput`). This PR adds a couple of helpers to the x-content-builder similar to what we have on `StreamOutput` to allow for faster serializing by avoiding the writer lookup and some self-reference checks.
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this when benchmarking large cluster states. When serializing collections we'd mostly
not take any advantage of what we know about the collection contents (like we do in
StreamOutput).This PR adds a couple of helpers to the x-content-builder similar to what we have on
StreamOutputto allow for faster serializing by avoiding the writer lookup and some self-reference checks.
backport of #78742