Revert "Remove MDP from PersistedClusterStateService (#72278)"#78495
Merged
rjernst merged 6 commits intoelastic:masterfrom Oct 4, 2021
Merged
Revert "Remove MDP from PersistedClusterStateService (#72278)"#78495rjernst merged 6 commits intoelastic:masterfrom
rjernst merged 6 commits intoelastic:masterfrom
Conversation
This reverts commit 2dfaf7a. The revert was not clean, it required merging with a few changes to loadOnDiskState since the initial removal of MDP support. relates elastic#71205
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
17 tasks
henningandersen
approved these changes
Oct 1, 2021
Comment on lines
+383
to
+388
| || acceptedTerm > maxAcceptedTerm | ||
| || (acceptedTerm == maxAcceptedTerm | ||
| && (onDiskState.lastAcceptedVersion > bestOnDiskState.lastAcceptedVersion | ||
| || (onDiskState.lastAcceptedVersion == bestOnDiskState.lastAcceptedVersion) | ||
| && onDiskState.currentTerm > bestOnDiskState.currentTerm))) { | ||
| bestOnDiskState = onDiskState; |
Contributor
There was a problem hiding this comment.
The formatting looks off here compared to original, I wonder if we can indent it according to parenthesis for readability?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 2dfaf7a.
The revert was not clean, it required merging with a few changes to
loadOnDiskState since the initial removal of MDP support.
relates #71205