Skip to content

Remove server jar accessDeclaredMembers permission#78431

Merged
romseygeek merged 1 commit intoelastic:masterfrom
romseygeek:sm/class-iterator-policy
Sep 29, 2021
Merged

Remove server jar accessDeclaredMembers permission#78431
romseygeek merged 1 commit intoelastic:masterfrom
romseygeek:sm/class-iterator-policy

Conversation

@romseygeek
Copy link
Copy Markdown
Contributor

@romseygeek romseygeek commented Sep 29, 2021

We added this permission to get CI passing with the initial lucene 9 upgrade,
but it turns out this was only necessary for SPI reloading of analysis components,
which we do separately. This commit removes the permission.

@romseygeek romseygeek self-assigned this Sep 29, 2021
@romseygeek romseygeek marked this pull request as draft September 29, 2021 08:14
@romseygeek
Copy link
Copy Markdown
Contributor Author

@elasticmachine run elasticsearch-ci/part-1

@romseygeek romseygeek changed the title Try removing accessDeclaredMembers permission Remove server jar accessDeclaredMembers permission Sep 29, 2021
@romseygeek romseygeek added :Core/Infra/Plugins Plugin API and infrastructure >non-issue labels Sep 29, 2021
@romseygeek romseygeek marked this pull request as ready for review September 29, 2021 10:01
@romseygeek romseygeek mentioned this pull request Sep 29, 2021
16 tasks
Copy link
Copy Markdown
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romseygeek romseygeek merged commit c364701 into elastic:master Sep 29, 2021
@romseygeek romseygeek deleted the sm/class-iterator-policy branch September 29, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants