Skip to content

Fix split package org.apache.lucene.analysis.miscellaneous#78205

Merged
ChrisHegarty merged 4 commits intoelastic:masterfrom
ChrisHegarty:relocate_lucene.analysis.miscellaneous
Sep 23, 2021
Merged

Fix split package org.apache.lucene.analysis.miscellaneous#78205
ChrisHegarty merged 4 commits intoelastic:masterfrom
ChrisHegarty:relocate_lucene.analysis.miscellaneous

Conversation

@ChrisHegarty
Copy link
Copy Markdown
Contributor

To allow for the future modularization of Elasticsearch with Java Modules, there are a number preparatory tasks that need be completed. This is one part of one such task: eliminate split packages.

Since recent Lucene upgrades, classes in org.apache.lucene.analysis.miscellaneous no longer require package-private access. This PR proposes to keep these classes in sever, but moved them to org.elasticsearch.lucene.analysis.miscellaneous. These classes are used by both server and common analysis plugin.

relates #78166

@ChrisHegarty ChrisHegarty added v8.0.0 modularization Java Modules related labels Sep 22, 2021
@ChrisHegarty ChrisHegarty self-assigned this Sep 22, 2021
Copy link
Copy Markdown
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisHegarty
Copy link
Copy Markdown
Contributor Author

@elasticmachine update branch

@ChrisHegarty ChrisHegarty added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Sep 22, 2021
@ChrisHegarty
Copy link
Copy Markdown
Contributor Author

@elasticmachine update branch

@ChrisHegarty ChrisHegarty removed the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Sep 23, 2021
@ChrisHegarty
Copy link
Copy Markdown
Contributor Author

@elasticmachine update branch

@ChrisHegarty ChrisHegarty merged commit f4755eb into elastic:master Sep 23, 2021
@ChrisHegarty ChrisHegarty deleted the relocate_lucene.analysis.miscellaneous branch September 23, 2021 10:24
@ChrisHegarty ChrisHegarty mentioned this pull request Sep 23, 2021
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

modularization Java Modules related v8.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants