Skip to content

Fix split package org.apache.lucene.util#78189

Merged
elasticsearchmachine merged 2 commits intoelastic:masterfrom
ChrisHegarty:relocate_CombinedBitSet
Sep 22, 2021
Merged

Fix split package org.apache.lucene.util#78189
elasticsearchmachine merged 2 commits intoelastic:masterfrom
ChrisHegarty:relocate_CombinedBitSet

Conversation

@ChrisHegarty
Copy link
Copy Markdown
Contributor

To allow for the future modularization of Elasticsearch with Java Modules, there are a number preparatory tasks that need be completed. This is one part of one such task: eliminate split packages.

Since recent Lucene upgrades, CombinedBitSet no longer requires package-private access. This PR proposes to keep CombinedBitSet in sever, but moved it to org.elasticsearch.lucene.util. CombinedBitSet is used by both server and x-pack-core.

relates #78166

@ChrisHegarty ChrisHegarty added v8.0.0 modularization Java Modules related labels Sep 22, 2021
@ChrisHegarty ChrisHegarty self-assigned this Sep 22, 2021
@ChrisHegarty ChrisHegarty changed the title Initial move commit, CombinedBitSet Fix split package org.apache.lucene.util Sep 22, 2021
@ChrisHegarty ChrisHegarty mentioned this pull request Sep 22, 2021
58 tasks
@ChrisHegarty
Copy link
Copy Markdown
Contributor Author

@elasticmachine test this please

Copy link
Copy Markdown
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrisHegarty
Copy link
Copy Markdown
Contributor Author

@elasticmachine test this please

1 similar comment
@ChrisHegarty
Copy link
Copy Markdown
Contributor Author

@elasticmachine test this please

@ChrisHegarty
Copy link
Copy Markdown
Contributor Author

@elasticmachine update branch

@ChrisHegarty ChrisHegarty added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Sep 22, 2021
@elasticsearchmachine elasticsearchmachine merged commit 5964ffe into elastic:master Sep 22, 2021
@ChrisHegarty ChrisHegarty deleted the relocate_CombinedBitSet branch September 22, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) modularization Java Modules related >non-issue v8.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants