Move ccr info/usage actions into ccr module#78137
Merged
rjernst merged 2 commits intoelastic:masterfrom Sep 22, 2021
Merged
Conversation
The ccr info and usage actions provide information through the xpack usage nad info apis. The implemenation classes should be in each individual module, yet for ccr they exist in xpack core, splitting the ccr package. This commit moves the classes into the ccr module to fix the split package.
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Member
Author
|
@elasticmachine update branch |
Member
Author
|
@elasticmachine run elasticsearch-ci/part-2 |
58 tasks
henningandersen
approved these changes
Sep 22, 2021
Contributor
henningandersen
left a comment
There was a problem hiding this comment.
LGTM. I wonder about the 7.x backport though since it looks so different?
Member
Author
It should still work in 7.x, just needs a different change. I'll backport it manually. |
Member
Author
|
Oh good news, the backport isn't even needed. In 7.x the info/usage classes are not in the same location, and there is no split package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ccr info and usage actions provide information through the xpack
usage nad info apis. The implemenation classes should be in each
individual module, yet for ccr they exist in xpack core, splitting the
ccr package. This commit moves the classes into the ccr module to fix
the split package.