Skip to content

Fix split package in netty4 module#78132

Merged
rjernst merged 2 commits intoelastic:masterfrom
rjernst:split-packages/netty
Sep 22, 2021
Merged

Fix split package in netty4 module#78132
rjernst merged 2 commits intoelastic:masterfrom
rjernst:split-packages/netty

Conversation

@rjernst
Copy link
Copy Markdown
Member

@rjernst rjernst commented Sep 21, 2021

The netty transport module reuses the transport package from server.
This commit moves the netty specific transport classes into the existing
o.e.transport.netty4 package.

The netty transport module reuses the transport package from server.
This commit moves the netty specific transport classes into the existing
o.e.transport.netty4 package.
@rjernst rjernst added >non-issue :Distributed/Network Http and internode communication implementations v8.0.0 v7.16.0 labels Sep 21, 2021
@rjernst rjernst requested a review from Tim-Brooks September 21, 2021 16:29
@elasticmachine elasticmachine added the Team:Distributed Meta label for distributed team. label Sep 21, 2021
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Copy Markdown
Contributor

@Tim-Brooks Tim-Brooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjernst rjernst merged commit fa94866 into elastic:master Sep 22, 2021
@rjernst rjernst deleted the split-packages/netty branch September 22, 2021 20:17
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

💔 Backport failed

Status Branch Result
7.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 78132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Network Http and internode communication implementations >non-issue Team:Distributed Meta label for distributed team. v7.16.0 v8.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants