Avoid unnecessary split package with lucene-highlighter#78099
Merged
elasticsearchmachine merged 2 commits intoelastic:masterfrom Sep 21, 2021
Merged
Avoid unnecessary split package with lucene-highlighter#78099elasticsearchmachine merged 2 commits intoelastic:masterfrom
elasticsearchmachine merged 2 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Contributor
Author
|
@elasticmachine update branch |
58 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To allow for the future modularization of Elasticsearch with Java Modules, there are a number preparatory tasks that need be completed. This is one such task: eliminate split packages.
Specifically, relocate
org.apache.lucene.search.uhighlighttoorg.elasticsearch.lucene.search.uhighlightto avoid unnecessary package-private dependencies on Lucene - unnecessary since Lucene 9.0.The relocation target package seems reasonable, supported by the fact that the existing tests already occupy that namespace.
Note: beyond the package rename, the only substantive change is to expose the protected member through an accessor - which avoids the need for package-private access.
relates #78166