Fix split package in analysis-icu plugin#78037
Merged
rjernst merged 3 commits intoelastic:masterfrom Sep 21, 2021
Merged
Conversation
The analysis-icu plugin reuses server package names for analysis and mappers. This commit moves the plugin implementation to use a single package name, o.e.p.analysis.icu
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
romseygeek
approved these changes
Sep 21, 2021
Contributor
romseygeek
left a comment
There was a problem hiding this comment.
LGTM, I left some questions around license headers.
We don't really have a good deprecation route for analysis plugins (it's pretty messy deprecating built-in analysis components as well). It would be nice to be able to cleanly say 'these components are deprecated' in the plugin definition. Something to add to the pile.
| @@ -1,4 +1,12 @@ | |||
| package org.elasticsearch.index.analysis; | |||
| /* | |||
Contributor
There was a problem hiding this comment.
This is a directly copy of lucene's old ICUCollationKeyFilter I think? In which case it should just keep the Apache 2 license header AIUI.
| @@ -1,4 +1,12 @@ | |||
| package org.elasticsearch.index.analysis; | |||
| /* | |||
| @@ -1,4 +1,12 @@ | |||
| package org.elasticsearch.index.analysis; | |||
| /* | |||
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
58 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The analysis-icu plugin reuses server package names for analysis and
mappers. This commit moves the plugin implementation to use a single
package name, o.e.p.analysis.icu