Conversation
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
Adds a basic test for tsdb with snapshot/restore.
|
|
||
| - match: {hits.total.value: 1} | ||
| - match: {hits.hits.0._source.k8s.pod.uid: 947e4ced-1786-4e53-9e0c-5c447e959507} | ||
| # TODO assert that the _tsid is correct after restore. |
There was a problem hiding this comment.
I'd love to use the same trick I use in #78028 to run an agg on tsid using a runtime field that looks like _tsid just to get the test a little more fleshed out. Just to have something we can look at before _tsid is generated. But, alas, painless isn't available to these tests.
imotov
left a comment
There was a problem hiding this comment.
I am a bit confused. Why do you only put this into hadoop repo and why hadoop?
|
I put it into Hadoop so I could run it. I can have another look, but I
didn't see any shared infrastructure for tests against all repos.
…On Tue, Sep 21, 2021, 18:11 Igor Motov ***@***.***> wrote:
***@***.**** commented on this pull request.
I am a bit confused. Why do you only put this into hadoop repo and why
hadoop?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#78022 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABUXIX3VI4VXXYEQ47GVN3UDD7IPANCNFSM5EMOB4MA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
I think it'd be more correct for me to run this with the fs repository in rest-api-spec. It'd be cool to have a thing that runs the same tests against all the repos but I don't think that is a "for now" thing. |
|
@imotov could you have another look? I've moved this into regular rest-api-tests which seems like the simplest thing. It'd be cool to be able to share snapshot/restore tests with a bunch of repos, but I don't think that is a "for now" problem. |
imotov
left a comment
There was a problem hiding this comment.
LGTM, I think you need to finish the hdfs cleanup though.
plugins/repository-hdfs/build.gradle
Outdated
| restResources { | ||
| restApi { | ||
| include '_common', 'cluster', 'nodes', 'indices', 'index', 'snapshot' | ||
| include '_common', 'bulk', 'cluster', 'index', 'indices', 'nodes', 'search', 'snapshot' |
Adds a basic test for tsdb with snapshot/restore.