Skip to content

[7.x] Handle master failure in NodeSeenService (#77220)#77527

Merged
elasticsearchmachine merged 1 commit intoelastic:7.xfrom
AthenaEryma:backport/7.x/pr-77220
Sep 9, 2021
Merged

[7.x] Handle master failure in NodeSeenService (#77220)#77527
elasticsearchmachine merged 1 commit intoelastic:7.xfrom
AthenaEryma:backport/7.x/pr-77220

Conversation

@AthenaEryma
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

* Handle master failure in NodeSeenService

NodeSeenService can miss seeing nodes if the master changes while it's
processing the cluster state update which adds the nodes to the cluster.
This caused occasional test failures in the test intended to check that
NodeSeenService is working as intended.

This commit adjusts NodeSeenService's early returns to ensure that, if
the master changed, the new master checks for seen nodes even if nodes
were not added in that particular cluster state update.

* Clarify & correct "just-became-master" check

* Remove leftover debug logging (d'oh!)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@AthenaEryma AthenaEryma added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport labels Sep 9, 2021
@elasticsearchmachine elasticsearchmachine merged commit 3d1f823 into elastic:7.x Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport v7.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants