Make enrich policy execution cancelable#77424
Merged
martijnvg merged 2 commits intoelastic:7.xfrom Sep 8, 2021
Merged
Conversation
The policy cancellation implementation is best-effort. Prior to each transport action call the policy runner checks whether the corresponding task has been cancelled. If so no further action is performed, otherwise execution is continued as planned. The policy execution tasks is also made the parent task of transport action requests that are being executed by the policy runner. This will allow cancellation when certain transport actions are being executed (e.g. reindex). Also it should provide better insight which other tasks are related to a policy execution task. Additionally, to this change a `step` field is added to the enrich policy status. This field will contain the name of the currently executing transport action request. This will help, giving better insight, what a policy execution is doing. Relates elastic#48988
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #77188 to 7.x branch.
The policy cancellation implementation is best-effort.
Prior to each transport action call the policy runner
checks whether the corresponding task has been cancelled.
If so no further action is performed, otherwise
execution is continued as planned.
The policy execution tasks is also made the parent task
of transport action requests that are being executed
by the policy runner. This will allow cancellation when
certain transport actions are being executed (e.g. reindex).
Also it should provide better insight which other tasks
are related to a policy execution task.
Additionally, to this change a
stepfield is added tothe enrich policy status. This field will contain
the name of the currently executing transport action
request. This will help, giving better insight, what
a policy execution is doing.
Relates #48988