add support for resetting dynamic cluster settings#7704
Closed
seut wants to merge 1 commit intoelastic:masterfrom
crate:s/reset-dynamic-settings
Closed
add support for resetting dynamic cluster settings#7704seut wants to merge 1 commit intoelastic:masterfrom crate:s/reset-dynamic-settings
seut wants to merge 1 commit intoelastic:masterfrom
crate:s/reset-dynamic-settings
Conversation
Contributor
|
Hi @seut Thanks for the PR. We'll take a look and get back to you |
Contributor
Author
|
any news on this? Of course I would rebase the master if there is any chance that this PR will be accepted.. |
Contributor
Author
|
just rebased the current master and updated the commit to respect new implemented settings. |
Contributor
|
@s1monw what do you think about this? |
Contributor
Author
|
any updates on this? |
Contributor
Contributor
Author
|
@clintongormley I understand. Will save my time with rebasing the current master until you'll accept the general logic of this code. Or otherwise, please poke me to rebase it. |
Contributor
|
thanks @seut |
Contributor
Contributor
Author
|
@s1monw sure take what you need ;) |
Contributor
|
closing since #15278 is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements support for resetting transient & persistent cluster settings to, either the configuration file value defined at node startup, or if it does not existed, the default value.
Resetting settings is done using the normal cluster update settings API, by just assigning a JSON
nullto the setting one want to reset. Seeupdate-settings.asciidocfor details.There are maybe other/smarter ways to do that, but I think this is just straight-forward and it works ;)
This is related to #6732, but does only apply to cluster settings not custom analyzer.