Skip to content

Feature/deprecation info max local storage nodes#76990

Merged
masseyke merged 3 commits intoelastic:7.xfrom
masseyke:feature/deprecation-info-max-local-storage-nodes
Sep 2, 2021
Merged

Feature/deprecation info max local storage nodes#76990
masseyke merged 3 commits intoelastic:7.xfrom
masseyke:feature/deprecation-info-max-local-storage-nodes

Conversation

@masseyke
Copy link
Copy Markdown
Member

@masseyke masseyke commented Aug 26, 2021

The "node.max_local_storage_nodes" property has been removed in 8.0. This commit adds a deprecation info
API check for the property.
Relates #42404 #42428

@masseyke masseyke requested a review from jbaiera August 26, 2021 17:19
@elasticmachine elasticmachine added the Team:Data Management (obsolete) DO NOT USE. This team no longer exists. label Aug 26, 2021
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@masseyke
Copy link
Copy Markdown
Member Author

Note: I cherry-picked a commit from #76986 into this one so that I didn't have to duplicate a bunch of boilerplate test code. So that one ought to go in first.

@masseyke masseyke linked an issue Aug 26, 2021 that may be closed by this pull request
80 tasks
Copy link
Copy Markdown
Member

@jbaiera jbaiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Feel free the merge that initial one in first.

@masseyke
Copy link
Copy Markdown
Member Author

masseyke commented Sep 1, 2021

@elasticmachine update branch

@elasticmachine
Copy link
Copy Markdown
Collaborator

merge conflict between base and head

@masseyke masseyke merged commit 15ff546 into elastic:7.x Sep 2, 2021
@masseyke masseyke deleted the feature/deprecation-info-max-local-storage-nodes branch September 2, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>non-issue Team:Data Management (obsolete) DO NOT USE. This team no longer exists. v7.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Deprecation Info API checks for 8.0

5 participants