Remote compression scheme default to deflate#76580
Merged
Tim-Brooks merged 5 commits intoelastic:7.xfrom Aug 16, 2021
Merged
Conversation
Currently the cluster.remote.*.transport.compression_scheme setting defaults to the `transport.compression_scheme` value. This commit modifies this to default to deflate (the existing compression scheme) prior to 7.14. This will ensure that users do not accidentally change their compression scheme for 7.x.
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
henningandersen
approved these changes
Aug 16, 2021
Comment on lines
+87
to
+89
| explicitBuilder.put(TransportSettings.TRANSPORT_COMPRESSION_SCHEME.getKey(), "lz4"); | ||
| ConnectionProfile connectionProfile = FakeConnectionStrategy.buildConnectionProfile("cluster-alias", explicitBuilder.build()); | ||
| assertEquals(Compression.Scheme.DEFLATE, connectionProfile.getCompressionScheme()); |
Contributor
There was a problem hiding this comment.
We may have it elsewhere, but if not, could we add assertions to validate that if REMOTE_CLUSTER_COMPRESSION_SCHEME is set, we use the value set there?
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
cluster.remote.*.transport.compression_schemesettingdefaults to the
transport.compression_schemevalue. This commitmodifies this to default to deflate (the existing compression scheme
prior to 7.14) when
cluster.remote.*.transport.compressis explicitly set.This will ensure that users do not accidentally change their compression
scheme for 7.x.