Fix Snapshot Out of Order Finalization Repo Corruption (#75362)#75415
Merged
original-brownbear merged 1 commit intoelastic:7.xfrom Jul 16, 2021
original-brownbear:75362-7.x
Merged
Fix Snapshot Out of Order Finalization Repo Corruption (#75362)#75415original-brownbear merged 1 commit intoelastic:7.xfrom original-brownbear:75362-7.x
original-brownbear merged 1 commit intoelastic:7.xfrom
original-brownbear:75362-7.x
Conversation
* Fix up shard generations in `SnapshotsInProgress` during snapshot finalization (don't do it earlier because it's a really heavy computation and we have a ton of places where it would have to run). * Adjust finalization queue to be able to work with changing snapshot entries after they've been enqueued for finalisation * Still one remaining bug left after this (see TODO about leaking generations) that I don't feel confident in fixing for `7.13.4` due to the complexity of a fix and how minor the blob leak is (+ it's cleaned up just fine during snapshot deletes) Closes #75336
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SnapshotsInProgressduring snapshot finalization (don't do it earlier because it's a really heavy computation and we have a ton of places where it would have to run).7.13.4due to the complexity of a fix and how minor the blob leak is (+ it's cleaned up just fine during snapshot deletes)Closes #75336
backport of #75362