Remove RAM accounting from segments#75274
Closed
jpountz wants to merge 19 commits intoelastic:mainfrom
Closed
Conversation
Collaborator
|
Pinging @elastic/es-core-features (Team:Core/Features) |
romseygeek
approved these changes
Jul 15, 2021
Contributor
romseygeek
left a comment
There was a problem hiding this comment.
LGTM, thanks @jpountz
Contributor
Author
|
I checked with @pgomulka regarding how to handle REST API version compatibility on this change, who suggested not handling |
Contributor
Author
|
For the record, I'm checking with the Stack Monitoring team whether that's something that'd be breaking for them and I'm holding merging until then. |
Member
|
Going to close this as it's very old. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pre-requisite for the upgrade to Lucene 9, which removes the ability to estimate RAM usage of segments.
I am checking impacts on the following components: