Skip to content

[Rest Api Compatibility] MoreLikeThisQuery with types#75123

Merged
pgomulka merged 6 commits intoelastic:masterfrom
pgomulka:compat/vectors_and_more_like_this
Jul 12, 2021
Merged

[Rest Api Compatibility] MoreLikeThisQuery with types#75123
pgomulka merged 6 commits intoelastic:masterfrom
pgomulka:compat/vectors_and_more_like_this

Conversation

@pgomulka
Copy link
Copy Markdown
Contributor

@pgomulka pgomulka commented Jul 8, 2021

previously removed in #42198
also adding a type for MultiTermVectorsResponse in failures

relates #54160
relates #51816

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@pgomulka
[Rest Api Compatibility] MoreLikeThisQuery with types
1e2f1b5 
previously removed in elastic#42198
also adding a type for MultiTermVectorsResponse in failures

relates elastic#54160
relates elastic#51816
@pgomulka pgomulka mentioned this pull request Jul 8, 2021
Closed
66 tasks
@pgomulka
Copy link
Copy Markdown
Contributor Author

pgomulka commented Jul 8, 2021

@elasticmachine run elasticsearch-ci/bwc

@pgomulka
Copy link
Copy Markdown
Contributor Author

pgomulka commented Jul 8, 2021

@elasticmachine update branch

@pgomulka pgomulka added the :Core/Infra/REST API REST infrastructure and utilities label Jul 8, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jul 8, 2021
@pgomulka pgomulka self-assigned this Jul 8, 2021
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Jul 8, 2021

Pinging @elastic/es-core-infra (Team:Core/Infra)

@pgomulka pgomulka requested a review from romseygeek July 8, 2021 15:46
romseygeek
romseygeek approved these changes Jul 12, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgomulka pgomulka merged commit ff8aede into elastic:master Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romseygeek romseygeek romseygeek approved these changes

Assignees

No one assigned

Labels

:Core/Infra/REST API REST infrastructure and utilities >enhancement Team:Core/Infra Meta label for core/infra team v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pgomulka @elasticmachine @romseygeek @jakelandis @elasticsearchmachine