Skip to content

[Rest Api Compatibility] Types for Percolate Query Api#74698

Merged
pgomulka merged 3 commits intoelastic:masterfrom
pgomulka:compat/percolator
Jun 30, 2021
Merged

[Rest Api Compatibility] Types for Percolate Query Api#74698
pgomulka merged 3 commits intoelastic:masterfrom
pgomulka:compat/percolator

Conversation

@pgomulka
Copy link
Copy Markdown
Contributor

@pgomulka pgomulka commented Jun 29, 2021 •
edited
Loading

Previously removed in #46985. The yaml test is included in this PR, but
will be removed once #74689 is merged.

relates #54160
relates main meta issue #51816

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@pgomulka
[Rest Api Compatibility] Types for Percolate Query Api
92afc0e 
Previously removed in elastic#46985. The yaml test is included in this PR, but
will be removed once elastic#74689 is merged.
@pgomulka pgomulka added :Core/Infra/REST API REST infrastructure and utilities v8.0.0 labels Jun 29, 2021
@pgomulka pgomulka self-assigned this Jun 29, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jun 29, 2021
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Jun 29, 2021

Pinging @elastic/es-core-infra (Team:Core/Infra)

This was referenced Jun 29, 2021
Merged
Closed
@mark-vieira
Copy link
Copy Markdown
Contributor

mark-vieira commented Jun 29, 2021

@elasticmachine retest this please

@pgomulka
Copy link
Copy Markdown
Contributor Author

pgomulka commented Jun 30, 2021

@elasticmachine run elasticsearch-ci/docs

@pgomulka pgomulka requested a review from romseygeek June 30, 2021 07:10
romseygeek
romseygeek approved these changes Jun 30, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

modules/percolator/build.gradle Outdated
apply plugin: 'elasticsearch.yaml-rest-test'
apply plugin: 'elasticsearch.yaml-rest-compat-test'
apply plugin: 'elasticsearch.internal-cluster-test'
apply plugin: 'elasticsearch.yaml-rest-compat-test'
Copy link
Copy Markdown
Contributor

@romseygeek romseygeek Jun 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a duplicate of line 9

@pgomulka pgomulka merged commit 603ebf7 into elastic:master Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romseygeek romseygeek romseygeek approved these changes

Assignees

No one assigned

Labels

:Core/Infra/REST API REST infrastructure and utilities >enhancement Team:Core/Infra Meta label for core/infra team v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pgomulka @elasticmachine @mark-vieira @romseygeek @jakelandis