[Rest Api Compatibility] Typed and xpack graph explore api#74185
Merged
pgomulka merged 4 commits intoelastic:masterfrom Jun 23, 2021
Merged
[Rest Api Compatibility] Typed and xpack graph explore api#74185pgomulka merged 4 commits intoelastic:masterfrom
pgomulka merged 4 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
adds back the typed and xpack endpoints for graph explore api prevoiusly removed in elastic#46935 relates main meta issue elastic#51816 relates types removal issue elastic#54160
989a817 to
e95dd9c
Compare
66 tasks
Contributor
Author
|
@elasticmachine update branch |
romseygeek
approved these changes
Jun 17, 2021
Contributor
romseygeek
left a comment
There was a problem hiding this comment.
LGTM - I left one comment about testing
| }); | ||
| } | ||
|
|
||
| public void testTypeInPath() { |
Contributor
There was a problem hiding this comment.
Maybe add a test for the _xpath variant as well?
Contributor
Author
There was a problem hiding this comment.
good point, in fact not all endpoints are correctly deprecated. /{index}/{type}/_xpack/graph/_explore api was indicating to use /{index}/{type}/_graph/explore
I will update this on 7.x and then update this PR too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds back the typed and xpack endpoints for graph explore api
prevoiusly removed in #46935
relates main meta issue #51816
relates types removal issue #54160
gradle check?