Prevent histogram from allocating tons of buckets (backport of #71758)#71986
Merged
nik9000 merged 1 commit intoelastic:7.xfrom Apr 21, 2021
Merged
Prevent histogram from allocating tons of buckets (backport of #71758)#71986nik9000 merged 1 commit intoelastic:7.xfrom
nik9000 merged 1 commit intoelastic:7.xfrom
Conversation
…c#71758) This prevents the `histogram` aggregation from allocating tons of empty buckets when you set the `interval` to something tiny. Instead, we reject the request. We're not in a place where we can aggregate over huge ranges with tiny intervals, but we should fail gracefully when you ask us to do so rather than OOM. Closes elastic#71744
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents the
histogramaggregation from allocating tons of emptybuckets when you set the
intervalto something tiny. Instead, wereject the request. We're not in a place where we can aggregate over
huge ranges with tiny intervals, but we should fail gracefully when you
ask us to do so rather than OOM.
Closes #71744