[Transform] add support for top metrics#71850
Merged
hendrikmuhs merged 7 commits intoelastic:masterfrom Apr 27, 2021
Merged
Conversation
hendrikmuhs
commented
Apr 19, 2021
...in/java/org/elasticsearch/search/aggregations/metrics/InternalNumericMetricsAggregation.java
Outdated
Show resolved
Hide resolved
hendrikmuhs
commented
Apr 19, 2021
...r/src/main/java/org/elasticsearch/search/aggregations/metrics/NumericMetricsAggregation.java
Outdated
Show resolved
Hide resolved
hendrikmuhs
commented
Apr 19, 2021
...analytics/src/main/java/org/elasticsearch/xpack/analytics/topmetrics/InternalTopMetrics.java
Outdated
Show resolved
Hide resolved
fbb7179 to
f5d4dc8
Compare
Author
|
I rebased this PR after #71738 got merged.
I created a new branch to explore this idea, see #71903. It is a nice cleanup and would make a lot of changes in this PR unnecessary. |
525a22a to
773076f
Compare
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
Author
|
After re-factorings of aggregations have been moved into another PR (#71903, merged) this PR only touches transform code. |
This was referenced Apr 23, 2021
benwtrent
reviewed
Apr 26, 2021
Member
benwtrent
left a comment
There was a problem hiding this comment.
Overall, great change. Its fantastic that we can reuse this dot delimited formatting for aggs. Shows that we have a nice framework design.
.../src/main/java/org/elasticsearch/xpack/transform/transforms/pivot/TransformAggregations.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/elasticsearch/xpack/transform/transforms/pivot/AggregationResultUtils.java
Outdated
Show resolved
Hide resolved
przemekwitek
approved these changes
Apr 27, 2021
.../src/main/java/org/elasticsearch/xpack/transform/transforms/pivot/TransformAggregations.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/elasticsearch/xpack/transform/transforms/pivot/TransformAggregations.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/elasticsearch/xpack/transform/transforms/pivot/TransformAggregations.java
Outdated
Show resolved
Hide resolved
4935d02 to
e91e901
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add support for the stats and top metrics aggregation in transform. With this change it became easier
to add more multi value aggregations to transform
Limitations:
doubleif mapping deduction is used, includingcount,sum,min,maxfixes #52236
relates #51925
Docs preview: https://elasticsearch_71850.docs-preview.app.elstc.co/diff