Make searchable snapshot cache size effectively zero on non-frozen nodes#71134
Merged
dakrone merged 3 commits intoelastic:7.xfrom Apr 1, 2021
Merged
Make searchable snapshot cache size effectively zero on non-frozen nodes#71134dakrone merged 3 commits intoelastic:7.xfrom
dakrone merged 3 commits intoelastic:7.xfrom
Conversation
This commits makes the shared_cache searchable snapshot cache size setting resolve to 0 for nodes that to do have the data_frozen node role. Tangentially related to elastic#70341 Supercedes elastic#70846
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
ywelsch
reviewed
Apr 1, 2021
Contributor
ywelsch
left a comment
There was a problem hiding this comment.
The message in HasFrozenCacheAllocationDecider.NO_FROZEN_CACHE should also be adapted as it is highly confusing now.
Member
Author
|
Thanks for bringing this up @ywelsch, I added a commit to change the message to clarify |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commits makes the shared_cache searchable snapshot cache size setting resolve to 0 for nodes
that to do have the data_frozen node role.
Tangentially related to #70341
Supercedes #70846
This only targets 7.x, because master will be handled by #71013