Align JSON logs better with ECS#67898
Merged
pugnascotia merged 2 commits intoelastic:7.xfrom Jan 26, 2021
Merged
Conversation
The JSON logs that Elasticsearch produces are roughly in an ECS shape. This PR improves that alignment.
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
pgomulka
approved these changes
Jan 26, 2021
server/src/main/java/org/elasticsearch/common/logging/ClusterIdConverter.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/common/logging/NodeIdConverter.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport / reimplementation of #67266.
The JSON logs that Elasticsearch produces are roughly in an ECS shape. This PR improves
that alignment. Since
7.xhas it's own version ofEcsJsonLayout, most of the changes are there, though I also had to backportClusterIdConverterandNodeIdConverter.