Warn of change of default of wait_for_active_shards#67527
Merged
DaveCTurner merged 1 commit intoelastic:7.xfrom Jan 14, 2021
Merged
Warn of change of default of wait_for_active_shards#67527DaveCTurner merged 1 commit intoelastic:7.xfrom
DaveCTurner merged 1 commit intoelastic:7.xfrom
Conversation
In 7.x the close indices API defaults to `?wait_for_active_shards=0` but from 8.0 it will default to respecting the index settings instead. This commit introduces the `index-setting` value for this parameter on this API allowing users to opt-in to the future behaviour today, and starts to emit a deprecation warning for users that use the default. Relates elastic#67158 Retry of elastic#67246 now that elastic#67498 is merged to `master` Closes elastic#66419
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Member
Author
|
See #67246 for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 7.x the close indices API defaults to
?wait_for_active_shards=0butfrom 8.0 it will default to respecting the index settings instead. This
commit introduces the
index-settingvalue for this parameter on thisAPI allowing users to opt-in to the future behaviour today, and starts
to emit a deprecation warning for users that use the default.
Relates #67158
Retry of #67246 now that #67498 is merged to
masterCloses #66419