Remove aggregation's postCollect phase (#64016)#64317
Merged
nik9000 merged 1 commit intoelastic:7.xfrom Oct 29, 2020
Merged
Conversation
After elastic#63811 it became clear to me that `postCollect` is kind of dangerous and not all that useful. So this removes it. The trouble with `postCollect` is that it all happened right after we finished calling `collect` on the `LeafBucketCollectors` but before we built the aggregation results. But in elastic#63811 we found out that we can't call `postCollect` on the children of `parent` or `child` aggregators until we know which *which* aggregation results we're building. So this removes `postCollect` and moves all of the things we did at post-collect phase into `buildAggregations` or into hooks called in those methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #63811 it became clear to me that
postCollectis kind ofdangerous and not all that useful. So this removes it.
The trouble with
postCollectis that it all happened right after wefinished calling
collecton theLeafBucketCollectorsbut before webuilt the aggregation results. But in #63811 we found out that we can't
call
postCollecton the children ofparentorchildaggregatorsuntil we know which which aggregation results we're building.
So this removes
postCollectand moves all of the things we did atpost-collect phase into
buildAggregationsor into hooks called inthose methods.